-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes 2554: Prevent having a webp bigger than the original #751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not understanding how the changes are preventing the WebP bigger than original?
Also, the referenced issue is not correct.
We also have this PR related #706 |
@CrochetFeve0251 Thanks for the update. Please find exploratory test notes below |
…webp' into enhancement/2554-prevent-bigger-webp
…webp' into enhancement/2554-prevent-bigger-webp
@Mai-Saad, thanks for the detailed report.
I do agree it seems a bit redundant with the message above saying WebP is not generated because it is bigger. It could be a small simplification, but let's see what @wp-media/productimagify thinks about this. We might not have all the cases in minds. In any case, that would be outside the scope of the issue.. |
@CrochetFeve0251 Thanks for the update. @MathieuLamiot Thanks for the feedback.
|
@CrochetFeve0251 Thanks for the update. Working as the following now. If agreed by @wp-media/productimagify then we can merge. /cc @MathieuLamiot
2- Original image is webP
3- Already on trunk, origional/ optimized size is not matching that in the upload folder https://wp-media.slack.com/archives/CU0F6EGQ1/p1699598198861799 4- Already on trunk, while display image in webp isnot checked, the used size at FE is that of webp but without adding webp extension https://wp-media.slack.com/archives/CU0F6EGQ1/p1699618969452739 |
Looks good. The only change is on the wording to make it clearer about why the origin image will be served instead: Change:
To:
|
…webp' into enhancement/2554-prevent-bigger-webp
Description
Fixes #2554
Display the message when we display a original format instead of the webp one.
Type of change
Please delete options that are not relevant.
Is the solution different from the one proposed during the grooming?
No.
Checklists
Generic development checklist
Test summary
If not, detail what you could not test.
Please describe any additional tests you performed.